Merged
Conversation
2 tasks
Kontinuation
added a commit
to wherobots/geo
that referenced
this pull request
Sep 25, 2025
… Rust compiler bug in 1.90.0 (#11) This patch removes the GAT `GeometryCollectionTypeExt` from `GeometryTraitExt` because it would introduce recursive GATs such as `G::GeometryCollectionTypeExt::GeometryTypeExt::GeometryCollectionTypeExt::...` and easily trigger a Rust compiler bug: rust-lang/rust#128887 and rust-lang/rust#131960. See also geoarrow/geoarrow-rs#1339. Although this could be worked around by not implementing generic functions using trait-based approach and use function-based approach instead, see geoarrow/geoarrow-rs#956 and georust/wkb#77, we are not certain if there will be other issues caused by recursive GATs in the future. So we decided to completely get rid of recursive GATs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #716. Ref georust/geo#1255 (comment).
Note that this is the same underlying implementation as upstream geo in georust/geo#1255. However, the trait-based implementation hits this compiler regression rust-lang/rust#128887, rust-lang/rust#131960, which prevents from compiling in release mode on a stable Rust version. For some reason, the function-based implementation does not hit this regression, and thus allows building geoarrow without using latest nightly and a custom
RUSTFLAGS.Note that it's only
GeometryTraitandGeometryCollectionTraitthat hit this compiler bug.Other traits can use the upstream impls.